DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 518497F3F7
Subject: Re: [PATCH v6 3/4] KVM: async_pf: Force a nested vmexit if the
 injected #PF is async_pf
To: Wanpeng Li <kernellwp@gmail.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>
References: <1498652712-10283-1-git-send-email-wanpeng.li@hotmail.com>
 <1498652712-10283-4-git-send-email-wanpeng.li@hotmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <293c4524-5869-2d3f-e0a3-92bde4430b81@redhat.com>
Date: Wed, 28 Jun 2017 14:56:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <1498652712-10283-4-git-send-email-wanpeng.li@hotmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 762
Lines: 23


On 28/06/2017 14:25, Wanpeng Li wrote:
> From: Wanpeng Li <wanpeng.li@hotmail.com>
> 
> Add an nested_apf field to vcpu->arch.exception to identify an async page 
> fault, and constructs the expected vm-exit information fields. Force a 
> nested VM exit from nested_vmx_check_exception() if the injected #PF is 
> async page fault. Extending the userspace interface KVM_GET_VCPU_EVENTS
> and KVM_SET_VCPU_EVENTS for live migration.
> 
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
> ---

Radim, Wanpeng,

the patch is nice now but I'm still not 100% sure about the live
migration part.  Why do we need to pass nested_apf to userspace, but not
nested_apf_token?

Paolo