Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751844AbdF1M6S (ORCPT ); Wed, 28 Jun 2017 08:58:18 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39838 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751511AbdF1M6M (ORCPT ); Wed, 28 Jun 2017 08:58:12 -0400 Date: Wed, 28 Jun 2017 14:58:09 +0200 From: Greg KH To: Simo Koskinen Cc: wporter82@gmail.com, dilekuzulmez@gmail.com, bankarsandhya512@gmail.com, colin.king@canonical.com, quexint@gmail.com, sergio.paracuellos@gmail.com, jrickertkc@gmail.com, julia.lawall@lip6.fr, namrataashettar@gmail.com, arushisinghal19971997@gmail.com, baijiaju1990@163.com, aquannie@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rts5208 : Fixing coding style warnings Message-ID: <20170628125809.GA30378@kroah.com> References: <20170628120021.GA10355@kroah.com> <1498654212-19521-1-git-send-email-koskisoft@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498654212-19521-1-git-send-email-koskisoft@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1161 Lines: 31 On Wed, Jun 28, 2017 at 02:50:12PM +0200, Simo Koskinen wrote: > Fixed following warnings found by checkpatch.pl script: > > WARNING: Prefer using '"%s...", __func__' to using 'xxxx', > this function's name, in a string > > Signed-off-by: Simo Koskinen Is this different from a previous patch? If so, you need to properly version your patch, as the documentation descripts how to do. > --- > drivers/staging/rts5208/rtsx.c | 2 -- > drivers/staging/rts5208/rtsx_chip.c | 4 ++-- > drivers/staging/rts5208/sd.c | 8 ++++---- > drivers/staging/rts5208/spi.c | 8 ++++---- > drivers/staging/rts5208/xd.c | 11 ++++++----- > 5 files changed, 16 insertions(+), 17 deletions(-) > > diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c > index b8177f5..c7ae702 100644 > --- a/drivers/staging/rts5208/rtsx.c > +++ b/drivers/staging/rts5208/rtsx.c > @@ -1009,8 +1009,6 @@ static void rtsx_remove(struct pci_dev *pci) > { > struct rtsx_dev *dev = pci_get_drvdata(pci); > > - dev_info(&pci->dev, "rtsx_remove() called\n"); > - This change does not match up with the changelog text :(