Reply-To: shuah@kernel.org
Subject: Re: [PATCH] selftests: ftrace: Use md5sum to take less time of
 checking logs
To: Masami Hiramatsu <mhiramat@kernel.org>,
        linux-kselftest@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        Shuah Khan <shuah@kernel.org>
References: <149855930170.10335.7114289594738299220.stgit@devbox>
From: Shuah Khan <shuah@kernel.org>
Message-ID: <88e2f665-dda9-c29d-fe4b-a13a0339cfd1@kernel.org>
Date: Wed, 28 Jun 2017 08:00:35 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <149855930170.10335.7114289594738299220.stgit@devbox>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1227
Lines: 39

On 06/27/2017 04:28 AM, Masami Hiramatsu wrote:
> Use md5sum so that it takes less time of checking
> trace logs update. Since busybox tail/cat takes too
> long time to read the trace log, this uses md5sum
> to check whether trace log is updated or not.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>

Applied to linux-kselftest next for 4.13-rc1

thanks,
-- Shuah

> ---
>  .../test.d/ftrace/func_traceonoff_triggers.tc      |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc
> index 9cf3852..7a9ab4f 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc
> @@ -103,11 +103,11 @@ if [ $on != "0" ]; then
>      fail "Tracing is not off"
>  fi
>  
> -line1=`cat trace | tail -1`
> +csum1=`md5sum trace`
>  sleep $SLEEP_TIME
> -line2=`cat trace | tail -1`
> +csum2=`md5sum trace`
>  
> -if [ "$line1" != "$line2" ]; then
> +if [ "$csum1" != "$csum2" ]; then
>      fail "Tracing file is still changing"
>  fi
>  
> 
> 
>