Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752105AbdF1OLj (ORCPT ); Wed, 28 Jun 2017 10:11:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56820 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbdF1OLe (ORCPT ); Wed, 28 Jun 2017 10:11:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 250194E4CB Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=pbonzini@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 250194E4CB Subject: Re: [PATCH v6 3/4] KVM: async_pf: Force a nested vmexit if the injected #PF is async_pf To: Wanpeng Li Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , "linux-kernel@vger.kernel.org" , kvm , Wanpeng Li References: <1498652712-10283-1-git-send-email-wanpeng.li@hotmail.com> <1498652712-10283-4-git-send-email-wanpeng.li@hotmail.com> <293c4524-5869-2d3f-e0a3-92bde4430b81@redhat.com> <20170628133852.GA3261@potion> From: Paolo Bonzini Message-ID: <810b3613-72e8-4f34-2757-e622f922ae03@redhat.com> Date: Wed, 28 Jun 2017 16:11:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 28 Jun 2017 14:11:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 630 Lines: 16 On 28/06/2017 16:09, Wanpeng Li wrote: >> Yes, this was my question essentially. I would still migrate >> nested_apf_token (as part of nested virt state), and then clear it in >> KVM when doing the async-pf broadcast. > Do you mean I should save nested_apf_token by GET_VCPU_EVENTS and > restore it by SET_VCPU_EVENTS? I utilize the place of "u8 pad" in > kvm_vcpu_events to hold nested_apf, however nested_apf_token is > unsigned long. If for now we can leave out the GET/SET_VCPU_EVENTS changes, that would be best. nested_apf and nested_apf_token should be migrated together with the rest of the nested virt state. Paolo