Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbdF1ORi (ORCPT ); Wed, 28 Jun 2017 10:17:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:53130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751616AbdF1ORc (ORCPT ); Wed, 28 Jun 2017 10:17:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3131214D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 28 Jun 2017 10:17:28 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org, Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: ftrace: Use md5sum to take less time of checking logs Message-ID: <20170628101728.5a41bed0@gandalf.local.home> In-Reply-To: <149855930170.10335.7114289594738299220.stgit@devbox> References: <149855930170.10335.7114289594738299220.stgit@devbox> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1279 Lines: 38 On Tue, 27 Jun 2017 19:28:32 +0900 Masami Hiramatsu wrote: > Use md5sum so that it takes less time of checking > trace logs update. Since busybox tail/cat takes too > long time to read the trace log, this uses md5sum > to check whether trace log is updated or not. How much faster is md5sum? I can see this causing issues in other environments. -- Steve > > Signed-off-by: Masami Hiramatsu > --- > .../test.d/ftrace/func_traceonoff_triggers.tc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc > index 9cf3852..7a9ab4f 100644 > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc > @@ -103,11 +103,11 @@ if [ $on != "0" ]; then > fail "Tracing is not off" > fi > > -line1=`cat trace | tail -1` > +csum1=`md5sum trace` > sleep $SLEEP_TIME > -line2=`cat trace | tail -1` > +csum2=`md5sum trace` > > -if [ "$line1" != "$line2" ]; then > +if [ "$csum1" != "$csum2" ]; then > fail "Tracing file is still changing" > fi >