DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 360BA214D7
Date: Wed, 28 Jun 2017 10:59:23 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Shuah Khan <shuah@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
        linux-kselftest@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: ftrace: Use md5sum to take less time of
 checking logs
Message-ID: <20170628105923.6bdaa9a3@gandalf.local.home>
In-Reply-To: <8f6497e7-8236-f0e0-0f51-87d691b9df8b@kernel.org>
References: <149855930170.10335.7114289594738299220.stgit@devbox>
        <20170628101728.5a41bed0@gandalf.local.home>
        <8f6497e7-8236-f0e0-0f51-87d691b9df8b@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1002
Lines: 27

On Wed, 28 Jun 2017 08:30:24 -0600
Shuah Khan <shuah@kernel.org> wrote:

> On 06/28/2017 08:17 AM, Steven Rostedt wrote:
> > On Tue, 27 Jun 2017 19:28:32 +0900
> > Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >   
> >> Use md5sum so that it takes less time of checking
> >> trace logs update. Since busybox tail/cat takes too
> >> long time to read the trace log, this uses md5sum
> >> to check whether trace log is updated or not.  
> > 
> > How much faster is md5sum? I can see this causing issues in other
> > environments.
> > 
> > -- Steve  
> 
> Sorry Steve. I pulled this into linux-ksefltest next. Are you concerned
> about any specific environments? I can try this out and see if it is a
> problem.

Yes please. I should probably do some playing too. I would like to fix
that test anyway, as it is one of the longer ones as I do a lot of
"paranoid checks". That is, I may go overboard in testing if tracing is
off or not, by checking to make sure its off using different tactics.

-- Steve