Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751827AbdF1PsX (ORCPT ); Wed, 28 Jun 2017 11:48:23 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52892 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbdF1PsR (ORCPT ); Wed, 28 Jun 2017 11:48:17 -0400 Date: Wed, 28 Jun 2017 17:48:08 +0200 From: Gerald Schaefer To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Suman Anna , Joerg Roedel Subject: Re: [PATCH 1/3] iommu: Return ERR_PTR() values from device_group call-backs In-Reply-To: <1498651258-23700-1-git-send-email-joro@8bytes.org> References: <1498651258-23700-1-git-send-email-joro@8bytes.org> Organization: IBM Deutschland Research & Development GmbH / Vorsitzende des Aufsichtsrats: Martina Koederitz / Geschaeftsfuehrung: Dirk Wittkopp / Sitz der Gesellschaft: Boeblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.23; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17062815-0012-0000-0000-000005592873 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062815-0013-0000-0000-000018CA8E21 Message-Id: <20170628174808.09a85fc6@thinkpad> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-28_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706280256 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1381 Lines: 52 On Wed, 28 Jun 2017 14:00:56 +0200 Joerg Roedel wrote: > From: Joerg Roedel > > The generic device_group call-backs in iommu.c return NULL > in case of error. Since they are getting ERR_PTR values from > iommu_group_alloc(), just pass them up instead. > > Reported-by: Gerald Schaefer > Signed-off-by: Joerg Roedel > --- Looks good, Reviewed-by: Gerald Schaefer > drivers/iommu/iommu.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index cf7ca7e..de09e1e 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -915,13 +915,7 @@ static int get_pci_alias_or_group(struct pci_dev *pdev, u16 alias, void *opaque) > */ > struct iommu_group *generic_device_group(struct device *dev) > { > - struct iommu_group *group; > - > - group = iommu_group_alloc(); > - if (IS_ERR(group)) > - return NULL; > - > - return group; > + return iommu_group_alloc(); > } > > /* > @@ -988,11 +982,7 @@ struct iommu_group *pci_device_group(struct device *dev) > return group; > > /* No shared group found, allocate new */ > - group = iommu_group_alloc(); > - if (IS_ERR(group)) > - return NULL; > - > - return group; > + return iommu_group_alloc(); > } > > /**