Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752253AbdF1P4n (ORCPT ); Wed, 28 Jun 2017 11:56:43 -0400 Received: from mail-wr0-f171.google.com ([209.85.128.171]:35640 "EHLO mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752117AbdF1P4d (ORCPT ); Wed, 28 Jun 2017 11:56:33 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170628091810.30484-1-fathi.boudra@linaro.org> <238b17a6-6284-eee3-4481-85d71c09b335@kernel.org> <48527cb0-319e-a964-43cb-08f64f4aaefa@kernel.org> From: Fathi Boudra Date: Wed, 28 Jun 2017 18:56:30 +0300 Message-ID: Subject: Re: [PATCH 1/1] selftests: timers: use LDLIBS instead of LDFLAGS to link against libpthread To: Shuah Khan Cc: linux-kselftest@vger.kernel.org, "linux-kernel@vger.kernel.org" , John Stultz , Denys Dmytriyenko Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3258 Lines: 76 On 28 June 2017 at 18:11, Shuah Khan wrote: > On 06/28/2017 09:00 AM, Fathi Boudra wrote: >> On 28 June 2017 at 17:41, Shuah Khan wrote: >>> On 06/28/2017 08:37 AM, Fathi Boudra wrote: >>>> On 28 June 2017 at 17:20, Shuah Khan wrote: >>>>> On 06/28/2017 03:18 AM, Fathi Boudra wrote: >>>>>> timers test fails to build due to undefined reference: >>>>>> >>>>>> aarch64-linaro-linux-gcc --sysroot=/build/tmp-rpb-glibc/sysroots/hikey >>>>>> -O2 -pipe -g -feliminate-unused-debug-types -O3 -Wl,-no-as-needed -Wall >>>>>> -DKTEST -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -lrt -lpthread >>>>>> posix_timers.c >>>>>> -o /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/timers/posix_timers >>>>>> /tmp/cc1FTZzT.o: In function `check_timer_create': >>>>>> /usr/src/debug/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/timers/posix_timers.c:157: >>>>>> undefined reference to `timer_create' >>>>>> /usr/src/debug/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/timers/posix_timers.c:170: >>>>>> undefined reference to `timer_settime' >>>>>> collect2: error: ld returned 1 exit status >>>>>> >>>>>> Use LDLIBS instead of LDFLAGS to properly link against libpthread and fix >>>>>> this build issue. >>>>>> >>>>>> Signed-off-by: Denys Dmytriyenko >>>>>> Signed-off-by: Fathi Boudra >>>>> >>>>> I can't reproduce this on linux-kselftest next on x86_64. Is this arm64 speocific >>>>> problem? Please try this on linux-kselftest latest. >>>> >>>> yes, I tried linux-kselftest next and can reproduce. >>>> Maybe related to native build vs cross-build? >>>> I don't think it's arm64 specific. >>>> >>> >>> Can you confirm that this change doesn't cause problems in native >>> build environments. >> >> yes, I tested on x86 in native build environment as well. It builds >> and run fine. >> >> I noticed my patchset for LDFLAGS vs LDLIBS changes don't apply >> cleanly on linux-kselftest next branch. I'm happy to respin the serie >> on top of next branch if you're willing to take them. >> > > Yeah. I knew your series won't apply on top of linux-kselftest next just > looking at that patches. Hence the question whether or not these problems > have been reproduced on linux-kselftest. > > Please redo the patches. The net patch needs to be done on top of > > SeongJae Park's fix > > selftest/net/Makefile: Specify output with $(OUTPUT) > > btw - with the the above fix, I don't see any failures on x86_64. > I am curious why it fails in cross-build? Could you figure out if > your cross-build environment is good. I'm using openembedded to cross-build a full distro, not only kselftest. I'm confident my cross-build environment is good. The issue encountered is the same as https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=next&id=dc816e5d84cbc28baf776799839a632d6002236f Using LDFLAGS vs LDLIBS affects the ordering of the linker flags. * with LDFLAGS aarch64-linux-gnu-gcc -lrt -lpthread posix_timers.c -o posix_timers * with LDLIBS aarch64-linux-gnu-gcc posix_timers.c -lrt -lpthread -o posix_timers > thanks, > -- Shuah > > thanks, > -- Shuah