Subject: Re: [PATCH/RFC 2/4] perf annotate: Add new source code view to the
 annotate TUI browser
To: Milian Wolff <milian.wolff@kdab.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Wang Nan <wangnan0@huawei.com>, Jin Yao <yao.jin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>, Kim Phillips <kim.phillips@arm.com>,
        David Ahern <dsahern@gmail.com>
References: <1498619652-763-1-git-send-email-treeze.taeung@gmail.com>
 <26773596.thloZocoZ7@milian-kdab2>
From: Taeung Song <treeze.taeung@gmail.com>
Message-ID: <a3b99a0f-3070-0b08-4c25-43931f597380@gmail.com>
Date: Thu, 29 Jun 2017 01:15:44 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <26773596.thloZocoZ7@milian-kdab2>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 841
Lines: 26

Hi, Milian :)

Thank you for your comment.

On 06/28/2017 06:44 PM, Milian Wolff wrote:
> On Wednesday, June 28, 2017 5:14:12 AM CEST Taeung Song wrote:
>> Unlike asm code level, the new source code view
>> provides a additional viewpoint based on source code level
>> for performance analysis.
>>
>> Of course, current disassembly view can show itself with pieces of source
>> code but some users want to check the result of performance analysis
>> based on full source code view. So add this view to the annotate TUI
>> browser.
>>
>> Users can switch to the new source code view by a 'S' key
>> and additionally support a 't' key toggling total period view.
> 
> The 't' key support should be a separate patch, I guess. It also does not
> update the column header (it stays at "Percent").
> 

Okey, I got it. will fix it!

Thanks,
Taeung