Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751815AbdF1QVq (ORCPT ); Wed, 28 Jun 2017 12:21:46 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:37165 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751489AbdF1QVj (ORCPT ); Wed, 28 Jun 2017 12:21:39 -0400 Subject: Re: [PATCH 4/4] remoteproc/keystone: Fix circular dependencies for ARM configs To: Bjorn Andersson CC: Ohad Ben-Cohen , Arnd Bergmann , , , References: <20170627224610.15321-1-s-anna@ti.com> <20170627224610.15321-5-s-anna@ti.com> <20170627234047.GN18666@tuxbook> From: Suman Anna Message-ID: <44a4b1bd-5faa-3b0e-1144-9bec0e3ad5cb@ti.com> Date: Wed, 28 Jun 2017 11:20:55 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170627234047.GN18666@tuxbook> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.58.153] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1488 Lines: 49 On 06/27/2017 06:40 PM, Bjorn Andersson wrote: > On Tue 27 Jun 15:46 PDT 2017, Suman Anna wrote: > >> Drop the dependency on RESET_CONTROLLER for the Keystone remoteproc >> driver to resolve some circular dependencies around different choices >> for RESET_CONTROLLER on common ARM configs. This dependency is >> inherent as the RESET_CONTROLLER will be enabled due to the enabled >> ARCH_HAS_RESET_CONTROLLER for ARCH_KEYSTONE. >> > > As my approach requires synchronized changes to rproc-next and > rpmsg-next and we're close to the merge window I'll pick this > "workaround" for now, thanks! > > I do think it's appropriate for the Keystone remoteproc driver to > express its dependency on reset-controller, so I intend to revert this > as I look into this issue after -rc1 again. > > Merged all 4 patches. Great, thanks. regards Suman > > Regards, > Bjorn > >> Signed-off-by: Suman Anna >> --- >> drivers/remoteproc/Kconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig >> index 945c1574f896..8891a8e50f12 100644 >> --- a/drivers/remoteproc/Kconfig >> +++ b/drivers/remoteproc/Kconfig >> @@ -70,7 +70,6 @@ config DA8XX_REMOTEPROC >> config KEYSTONE_REMOTEPROC >> tristate "Keystone Remoteproc support" >> depends on ARCH_KEYSTONE >> - depends on RESET_CONTROLLER >> select RPMSG_VIRTIO >> help >> Say Y here here to support Keystone remote processors (DSP) >> -- >> 2.13.1 >>