Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790AbdF1Qiq (ORCPT ); Wed, 28 Jun 2017 12:38:46 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46954 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbdF1Qip (ORCPT ); Wed, 28 Jun 2017 12:38:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E3AD6601EA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: ti: wl18xx: add checks on wl18xx_top_reg_write() return value From: Kalle Valo In-Reply-To: <20170626230619.GA14831@embeddedgus> References: <20170626230619.GA14831@embeddedgus> To: "Gustavo A. R. Silva" Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20170628163844.455B5605BD@smtp.codeaurora.org> Date: Wed, 28 Jun 2017 16:38:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 512 Lines: 16 "Gustavo A. R. Silva" wrote: > Check return value from call to wl18xx_top_reg_write(), > so in case of error jump to goto label out and return. > > Also, remove unnecessary value check before goto label out. > > Addresses-Coverity-ID: 1226938 > Signed-off-by: Gustavo A. R. Silva The prefix should be "wl18xx:", I'll fix that. -- https://patchwork.kernel.org/patch/9810591/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches