Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751899AbdF1QjM (ORCPT ); Wed, 28 Jun 2017 12:39:12 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:49333 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbdF1QjK (ORCPT ); Wed, 28 Jun 2017 12:39:10 -0400 From: wenxiong@linux.vnet.ibm.com To: linux-kernel@vger.kernel.org Cc: keith.busch@intel.com, axboe@fb.com, bjking@linux.vnet.ibm.com, wenxiong@linux.vnet.ibm.com Subject: [PATCH] fs: System memory leak when running HTX with T10 DIF enabled Date: Wed, 28 Jun 2017 11:32:51 -0500 X-Mailer: git-send-email 1.7.1 X-TM-AS-MML: disable x-cbid: 17062816-0028-0000-0000-000001C57C75 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062816-0029-0000-0000-000014C6E065 Message-Id: <1498667571-14275-1-git-send-email-wenxiong@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-28_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=3 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706280267 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2557 Lines: 78 From: Wen Xiong With nvme devive + T10 enabled, On a system it has 256GB and started logging /proc/meminfo & /proc/slabinfo for every minute and in an hour it increased by 15968128 kB or ~15+GB.. Approximately 256 MB / minute leaking. /proc/meminfo | grep SUnreclaim... SUnreclaim: 6752128 kB SUnreclaim: 6874880 kB SUnreclaim: 7238080 kB .... SUnreclaim: 22307264 kB SUnreclaim: 22485888 kB SUnreclaim: 22720256 kB When testcases with T10 enabled call into __blkdev_direct_IO_simple, code doesn't free memory allocated by bio_integrity_alloc. The patch fixes the issue. HTX has been run with +60 hours without failure. failing stack: [36587.216329] [c000002ff60874a0] [c000000000bcac68] dump_stack+0xb0/0xf0 (unreliable) [36587.216349] [c000002ff60874e0] [c000000000bc8c94] panic+0x140/0x308 [36587.216407] [c000002ff6087570] [c000000000282530] out_of_memory+0x4e0/0x650 [36587.216465] [c000002ff6087610] [c00000000028a154] __alloc_pages_nodemask+0xf34/0x10b0 [36587.216534] [c000002ff6087810] [c00000000030b800] alloc_pages_current+0xc0/0x1d0 [36587.216603] [c000002ff6087870] [c00000000031907c] new_slab+0x46c/0x7d0 [36587.216661] [c000002ff6087950] [c00000000031bf00] ___slab_alloc+0x570/0x670 [36587.216718] [c000002ff6087a70] [c00000000031c05c] __slab_alloc+0x5c/0x90 [36587.216776] [c000002ff6087ad0] [c00000000031c1f4] kmem_cache_alloc+0x164/0x300 [36587.216845] [c000002ff6087b20] [c0000000002de120] mmap_region+0x3e0/0x6e0 [36587.216903] [c000002ff6087c00] [c0000000002de7cc] do_mmap+0x3ac/0x480 [36587.216960] [c000002ff6087c80] [c0000000002af244] vm_mmap_pgoff+0x114/0x160 [36587.217018] [c000002ff6087d60] [c0000000002db6b0] SyS_mmap_pgoff+0x230/0x300 [36587.217087] [c000002ff6087de0] [c000000000014eac] sys_mmap+0x8c/0xd0 [36587.217145] [c000002ff6087e30] [c00000000000b184] system_call+0x38/0xe0 [36587.217481] ---[ end Kernel panic - not syncing: Out of memory and no killable processes... [36587.217481] Signed-off-by: Wen Xiong Reviewed by: Brian King Tested by: Murali Iyer --- fs/block_dev.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/fs/block_dev.c b/fs/block_dev.c index 519599d..e871444 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -264,6 +264,10 @@ static void blkdev_bio_end_io_simple(struct bio *bio) if (unlikely(bio.bi_error)) return bio.bi_error; + + if (bio_integrity(&bio)) + bio_integrity_free(&bio); + return ret; } -- 1.7.1