Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751797AbdF1RWM (ORCPT ); Wed, 28 Jun 2017 13:22:12 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42714 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbdF1RWE (ORCPT ); Wed, 28 Jun 2017 13:22:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 057CD60879 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=riteshh@codeaurora.org Subject: Re: [RFC PATCH 0/2] mmc: sdhci: Add SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER To: srinivas.kandagatla@linaro.org, Adrian Hunter , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20170628133504.17422-1-srinivas.kandagatla@linaro.org> From: Ritesh Harjani Message-ID: <552ef0ba-91d5-ab9c-d55c-ac008608a689@codeaurora.org> Date: Wed, 28 Jun 2017 22:51:57 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170628133504.17422-1-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 46 Hi Srinivas, On 6/28/2017 7:05 PM, srinivas.kandagatla@linaro.org wrote: > From: Srinivas Kandagatla > > This patchset adds quirk to support cards which have issues when sdma > boundary buffer bits are programmed in Block Size Register (0x04) > when using ADMA. Thanks for pointing out the reason of failure without this patch. Earlier I could not find the reason. Previous discussion link :- https://patchwork.kernel.org/patch/9200579/ > > First patch adds quirk and second one uses that quirk in msm sdhci driver. Not sure if quirk will be the right way to go about this, or whether we should make this functionality default since ADMA does not uses this (as per spec) ? Since other systems should not break (as Adrian was mentioning in the discussion link above). Adrian/Ulf will know better on this. > > Tested on DB410c with WLAN SDIO card. > > thanks, > srini > > Srinivas Kandagatla (2): > mmc: sdhci: add quirk SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER > mmc: sdhci-msm: enable SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER > > drivers/mmc/host/sdhci-msm.c | 3 ++- > drivers/mmc/host/sdhci.c | 24 ++++++++++++++++++------ > drivers/mmc/host/sdhci.h | 2 ++ > 3 files changed, 22 insertions(+), 7 deletions(-) > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project