Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751888AbdF1Rvi (ORCPT ); Wed, 28 Jun 2017 13:51:38 -0400 Received: from mail-pg0-f42.google.com ([74.125.83.42]:35492 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515AbdF1Rvd (ORCPT ); Wed, 28 Jun 2017 13:51:33 -0400 Subject: Re: [PATCH] fs: System memory leak when running HTX with T10 DIF enabled To: Keith Busch , wenxiong@linux.vnet.ibm.com Cc: linux-kernel@vger.kernel.org, bjking@linux.vnet.ibm.com, hch@lst.de References: <1498667571-14275-1-git-send-email-wenxiong@linux.vnet.ibm.com> <20170628171031.GC2650@localhost.localdomain> From: Jens Axboe Message-ID: Date: Wed, 28 Jun 2017 11:51:30 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170628171031.GC2650@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 620 Lines: 23 On 06/28/2017 11:10 AM, Keith Busch wrote: > On Wed, Jun 28, 2017 at 11:32:51AM -0500, wenxiong@linux.vnet.ibm.com wrote: >> diff --git a/fs/block_dev.c b/fs/block_dev.c >> index 519599d..e871444 100644 >> --- a/fs/block_dev.c >> +++ b/fs/block_dev.c >> @@ -264,6 +264,10 @@ static void blkdev_bio_end_io_simple(struct bio *bio) >> >> if (unlikely(bio.bi_error)) >> return bio.bi_error; >> + >> + if (bio_integrity(&bio)) >> + bio_integrity_free(&bio); >> + >> return ret; >> } > > We don't want to leak the integrity payload in case of bi_error either. Yep, see my follow up email on this. -- Jens Axboe