Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752230AbdF1Rw1 (ORCPT ); Wed, 28 Jun 2017 13:52:27 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:35029 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751532AbdF1RwT (ORCPT ); Wed, 28 Jun 2017 13:52:19 -0400 Date: Wed, 28 Jun 2017 10:52:16 -0700 From: Guenter Roeck To: Christopher Bostic Cc: wim@iguana.be, robh+dt@kernel.org, mark.rutland@arm.com, joel@jms.id.au, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config Message-ID: <20170628175216.GA13730@roeck-us.net> References: <20170627211734.60477-1-cbostic@linux.vnet.ibm.com> <20170627211734.60477-3-cbostic@linux.vnet.ibm.com> <606a2e11-2d43-5204-0bb6-9c4415ee03df@roeck-us.net> <20170628145452.GA30968@roeck-us.net> <38e57720-9728-9377-2a16-adc8ce430ca0@linux.vnet.ibm.com> <20170628150846.GE30968@roeck-us.net> <20170628160649.GB8915@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 747 Lines: 19 On Wed, Jun 28, 2017 at 11:09:15AM -0500, Christopher Bostic wrote: > > >> > >>Why would there even be a need configure for no system reset? The external > >>mode 'wdt ext: External signal enable after timeout' can be sent off chip > >>even if system reset is disabled. The watchdog is doing something in this > >>case and would require wdt instantiation. > >> > >Wouldn't that be "aspeed,external-signal" ? > Yes that optional parameter would need to be specified in that situation, as > well as 'aspeed,no-system-reset'. > Ok, makes sense (after looking into the datasheet). The missing detail is that there is a separate configuration bit for "Reset system after timeout", which is set in addition to reset_{sys,soc,arm}. Thanks, Guenter