Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751755AbdF1SPA (ORCPT ); Wed, 28 Jun 2017 14:15:00 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:42016 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbdF1SOw (ORCPT ); Wed, 28 Jun 2017 14:14:52 -0400 Date: Wed, 28 Jun 2017 19:12:05 +0100 From: Mark Brown To: Chen-Yu Tsai Cc: Maxime Ripard , Danny Milosavljevic , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Linux-ALSA , linux-arm-kernel , linux-kernel , linux-sunxi Message-ID: <20170628181205.sfagsnuqmfrqhoen@sirena.org.uk> References: <20170624062419.23778-1-dannym@scratchpost.org> <20170624062419.23778-6-dannym@scratchpost.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aumdev75eqsgqzhc" Content-Disposition: inline In-Reply-To: X-Cookie: 667: User-Agent: NeoMutt/20170609 (1.8.3) X-SA-Exim-Connect-IP: 92.40.248.108 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v13 05/14] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls. X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1807 Lines: 45 --aumdev75eqsgqzhc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 26, 2017 at 09:48:59AM +0800, Chen-Yu Tsai wrote: > On Sat, Jun 24, 2017 at 2:24 PM, Danny Milosavljevic > > +static const struct snd_kcontrol_new sun4i_codec_mixer_controls[] = { > > + SOC_DAPM_DOUBLE("DAC Playback Switch", SUN4I_CODEC_DAC_ACTL, > > + SUN4I_CODEC_DAC_ACTL_LDACLMIXS, > > SUN4I_CODEC_DAC_ACTL_RDACRMIXS, 1, 0), > This changes the mixer control names exposed to userspace. While I think > consolidating mixer controls is nice, giving the user a less cluttered > view, I'm not sure about the changing a possible userspace ABI. > Maxime, ALSA and ASoC people, any comments about this? It's better not to change things but on the other hand it really depends if there's any users who will notice - if nobody notices it doesn't matter. Can we *please* get some review of the rest of this series? It's enormous, we're on version *13* and the first review on this version here is on patch 5. If the first four patches are fine then please says so, if they're not then let's have some review comments so things can move towards merging them. --aumdev75eqsgqzhc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAllT8XQACgkQJNaLcl1U h9AqXQf/dA3v+EhX5jDdhpa++SfrJCcDP1YGj5aw+ndzcKrY+BJD/55JwohdMPxB 5TICseIByPsWeDc8juAsPVjPi5tW8ygOBqXf59qoB2nvzj01XuTUU9s3RhBcn2bw yxVNpBIRKsSvW02Dk3fscHxSTT6r44UqA/vSQq/kEhsnmpKm9GpEVqqfyPnSyc3k EghhiMK/diU9LRgKOeRwV+HUXpK7kDaSXetrVFo30LDlKH3Nion7PSpZJOHZYUa9 wrDjvAMMRxEhU3abyNK17p2JOhWZIzMm0cnD5QNVuaqMFtYPLmg1yV+oo9km/s6q W7fgcK99Y8m9AvasmKFUrrLa1l5d9w== =O/bb -----END PGP SIGNATURE----- --aumdev75eqsgqzhc--