Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751744AbdF1SQ2 (ORCPT ); Wed, 28 Jun 2017 14:16:28 -0400 Received: from mail-wr0-f172.google.com ([209.85.128.172]:35167 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbdF1SQT (ORCPT ); Wed, 28 Jun 2017 14:16:19 -0400 Subject: Re: [RFC PATCH 0/2] mmc: sdhci: Add SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER To: Ritesh Harjani , Adrian Hunter , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20170628133504.17422-1-srinivas.kandagatla@linaro.org> <552ef0ba-91d5-ab9c-d55c-ac008608a689@codeaurora.org> From: Srinivas Kandagatla Message-ID: <799ab3c1-ef36-0137-0064-63823c1598d3@linaro.org> Date: Wed, 28 Jun 2017 19:16:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <552ef0ba-91d5-ab9c-d55c-ac008608a689@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1657 Lines: 58 On 28/06/17 18:21, Ritesh Harjani wrote: > Hi Srinivas, > > On 6/28/2017 7:05 PM, srinivas.kandagatla@linaro.org wrote: >> From: Srinivas Kandagatla >> >> This patchset adds quirk to support cards which have issues when sdma >> boundary buffer bits are programmed in Block Size Register (0x04) >> when using ADMA. > > Thanks for pointing out the reason of failure without this patch. > Earlier I could not find the reason. > > Previous discussion link :- > https://patchwork.kernel.org/patch/9200579/ I did see this patch, only issue I had is making it default. > > >> >> First patch adds quirk and second one uses that quirk in msm sdhci >> driver. > > Not sure if quirk will be the right way to go about this, or whether we > should make this functionality default since ADMA does not > uses this (as per spec) ? > Since other systems should not break (as Adrian was mentioning in the > discussion link above). > That was the only reason to add this as quirk, so that other drivers would work as it previously. Also, this seems to be a issue with only qcom controller, so quirk makes more sense for me. > Adrian/Ulf will know better on this. > --srini >> >> Tested on DB410c with WLAN SDIO card. >> >> thanks, >> srini >> >> Srinivas Kandagatla (2): >> mmc: sdhci: add quirk SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER >> mmc: sdhci-msm: enable SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER >> >> drivers/mmc/host/sdhci-msm.c | 3 ++- >> drivers/mmc/host/sdhci.c | 24 ++++++++++++++++++------ >> drivers/mmc/host/sdhci.h | 2 ++ >> 3 files changed, 22 insertions(+), 7 deletions(-) >> >