Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751704AbdF1Si0 (ORCPT ); Wed, 28 Jun 2017 14:38:26 -0400 Received: from verein.lst.de ([213.95.11.211]:50925 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbdF1SiU (ORCPT ); Wed, 28 Jun 2017 14:38:20 -0400 Date: Wed, 28 Jun 2017 20:38:18 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Keith Busch , wenxiong@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, bjking@linux.vnet.ibm.com Subject: Re: [PATCH] fs: System memory leak when running HTX with T10 DIF enabled Message-ID: <20170628183818.GA12860@lst.de> References: <1498667571-14275-1-git-send-email-wenxiong@linux.vnet.ibm.com> <20170628171031.GC2650@localhost.localdomain> <20170628183141.GA12722@lst.de> <0fa90019-5b07-7afb-8915-17c54a22709b@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0fa90019-5b07-7afb-8915-17c54a22709b@fb.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 430 Lines: 13 On Wed, Jun 28, 2017 at 12:34:15PM -0600, Jens Axboe wrote: > That's what I sent out. Where? Didn't see that anywhere.. > Here it is again. We should get this into 4.12, > so would be great with a review or two. Can we rename __bio_free to bio_uninit and add a comment to bio_init that it must be paried with bio_uninit? Except for that this looks fine, although there are a lot more callers that should get this treatment..