Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751754AbdF1Txh (ORCPT ); Wed, 28 Jun 2017 15:53:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:54642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbdF1Tx2 (ORCPT ); Wed, 28 Jun 2017 15:53:28 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CAE822B5A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Wed, 28 Jun 2017 14:53:26 -0500 From: Bjorn Helgaas To: Ryder Lee Cc: Bjorn Helgaas , Rob Herring , Arnd Bergmann , devicetree@vger.kernel.org, Red Hung , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 1/2] PCI: mediatek: Add Mediatek PCIe host controller support Message-ID: <20170628195325.GR17844@bhelgaas-glaptop.roam.corp.google.com> References: <1495338145-9384-1-git-send-email-ryder.lee@mediatek.com> <1495338145-9384-2-git-send-email-ryder.lee@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495338145-9384-2-git-send-email-ryder.lee@mediatek.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 26 On Sun, May 21, 2017 at 11:42:24AM +0800, Ryder Lee wrote: > Add support for the Mediatek PCIe Gen2 controller which can > be found on MT7623 series SoCs. > > Signed-off-by: Ryder Lee > --- > drivers/pci/host/Kconfig | 11 + > drivers/pci/host/Makefile | 1 + > drivers/pci/host/pcie-mediatek.c | 553 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 565 insertions(+) > create mode 100644 drivers/pci/host/pcie-mediatek.c >... > +static int mtk_pcie_register_host(struct pci_host_bridge *host) > +{ > + struct mtk_pcie *pcie = pci_host_bridge_priv(host); > + struct pci_bus *child; > + int err; > + > + pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS); Do you really need the PCI_REASSIGN_ALL_RSRC and PCI_REASSIGN_ALL_BUS flags? I'd like to get rid of them because we should automatically assign resources if the firmware hasn't done it. Bjorn