Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751583AbdF1VJc (ORCPT ); Wed, 28 Jun 2017 17:09:32 -0400 Received: from mail-yb0-f175.google.com ([209.85.213.175]:34787 "EHLO mail-yb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbdF1VJ1 (ORCPT ); Wed, 28 Jun 2017 17:09:27 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Dan Williams Date: Wed, 28 Jun 2017 14:09:25 -0700 Message-ID: Subject: Re: [PATCH v2 4/7] acpi, nfit: Use bus_dsm_mask for passthru To: Jerry Hoemann Cc: "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 996 Lines: 24 On Tue, Jun 20, 2017 at 9:51 AM, Jerry Hoemann wrote: > Populate bus_dsm_mask and use it to filter dsm calls that user can > make through the pass thru interface. > > Signed-off-by: Jerry Hoemann > --- > drivers/acpi/nfit/core.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index b46fca2..9d281a4 100644 > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -253,6 +253,7 @@ int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm, > cmd_name = nvdimm_bus_cmd_name(cmd); > cmd_mask = nd_desc->cmd_mask; > dsm_mask = cmd_mask; > + if (cmd == ND_CMD_CALL) dsm_mask = nd_desc->bus_dsm_mask; Checkpatch complains about this: ERROR: trailing statements should be on next line #118: FILE: drivers/acpi/nfit/core.c:256: + if (cmd == ND_CMD_CALL) dsm_mask = nd_desc->bus_dsm_mask;