Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751626AbdF1VNJ (ORCPT ); Wed, 28 Jun 2017 17:13:09 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34952 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbdF1VNC (ORCPT ); Wed, 28 Jun 2017 17:13:02 -0400 Date: Wed, 28 Jun 2017 14:13:00 -0700 (PDT) X-Google-Original-Date: Wed, 28 Jun 2017 14:12:53 PDT (-0700) From: Palmer Dabbelt To: merker@debian.org CC: peterz@infradead.org CC: mingo@redhat.com CC: mcgrof@kernel.org CC: viro@zeniv.linux.org.uk CC: sfr@canb.auug.org.au CC: nicolas.dichtel@6wind.com CC: rmk+kernel@armlinux.org.uk CC: msalter@redhat.com CC: tklauser@distanz.ch CC: will.deacon@arm.com CC: james.hogan@imgtec.com CC: paul.gortmaker@windriver.com CC: linux@roeck-us.net CC: linux-kernel@vger.kernel.org CC: linux-arch@vger.kernel.org CC: albert@sifive.com Subject: Re: [PATCH 9/9] RISC-V: Build Infastructure In-Reply-To: <20170628210513.iao6g7mvobe4jlqy@excalibur.cnev.de> Message-ID: Mime-Version: 1.0 (MHng) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1831 Lines: 44 On Wed, 28 Jun 2017 14:05:14 PDT (-0700), merker@debian.org wrote: > On Wed, Jun 28, 2017 at 11:55:38AM -0700, Palmer Dabbelt wrote: >> This patch contains all the build infastructure that actually enables >> the RISC-V port. This includes Makefiles, linker scripts, and Kconfig >> files. It also contains the only top-level change, which adds RISC-V to >> the list of architectures that need a sed run to produce the ARCH >> variable when building locally. >> >> Signed-off-by: Palmer Dabbelt >> --- > [...] >> diff --git a/arch/riscv/configs/freedom-u500_defconfig b/arch/riscv/configs/freedom-u500_defconfig >> new file mode 100644 >> index 000000000000..b37908d45067 >> --- /dev/null >> +++ b/arch/riscv/configs/freedom-u500_defconfig >> @@ -0,0 +1,53 @@ >> +CONFIG_CROSS_COMPILE="riscv64-unknown-linux-gnu-" > > just a tiny nitpick: defconfigs shouldn't predefine a crosscompiler > prefix. That has already been fixed in the other defconfigs at > some earlier point in time, but IIRC the freedom-u500_defconfig got > added later on and it was probably overlooked then. Oh, sorry about that -- you're right, I just missed that one as it wasn't in the original patch set. I'll squash this in when we do a v4. commit 1a262894827be647d55016da09f61eb49962dd7d Author: Palmer Dabbelt Date: Wed Jun 28 14:11:17 2017 -0700 Don't define CROSS_COMPILE in the u500 defconfig diff --git a/arch/riscv/configs/freedom-u500_defconfig b/arch/riscv/configs/freedom-u500_defconfig index b37908d45067..b580dc5c8feb 100644 --- a/arch/riscv/configs/freedom-u500_defconfig +++ b/arch/riscv/configs/freedom-u500_defconfig @@ -1,4 +1,3 @@ -CONFIG_CROSS_COMPILE="riscv64-unknown-linux-gnu-" CONFIG_DEFAULT_HOSTNAME="ucbvax" # CONFIG_CROSS_MEMORY_ATTACH is not set # CONFIG_FHANDLE is not set