Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751899AbdF1VZr (ORCPT ); Wed, 28 Jun 2017 17:25:47 -0400 Received: from verein.lst.de ([213.95.11.211]:51609 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751782AbdF1VZp (ORCPT ); Wed, 28 Jun 2017 17:25:45 -0400 Date: Wed, 28 Jun 2017 23:25:43 +0200 From: Christoph Hellwig To: Shaohua Li Cc: Jens Axboe , Christoph Hellwig , Keith Busch , wenxiong@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, bjking@linux.vnet.ibm.com Subject: Re: [PATCH] fs: System memory leak when running HTX with T10 DIF enabled Message-ID: <20170628212543.GA19180@lst.de> References: <1498667571-14275-1-git-send-email-wenxiong@linux.vnet.ibm.com> <20170628171031.GC2650@localhost.localdomain> <20170628183141.GA12722@lst.de> <0fa90019-5b07-7afb-8915-17c54a22709b@fb.com> <20170628183818.GA12860@lst.de> <20170628185235.GA13126@lst.de> <9308965a-f9c2-54b3-ae0c-65dcdd7514fb@fb.com> <20170628211131.la2n3gi7xbjlkzvj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170628211131.la2n3gi7xbjlkzvj@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 263 Lines: 5 On Wed, Jun 28, 2017 at 02:11:31PM -0700, Shaohua Li wrote: > I fixed the same issue in the blktrace patches. It did the free in bio_endio. Moving all the frees to bio_endio does indeed seem sensible, as it avoids the additional calls for the bio_init()ed bios.