Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbdF1WXM (ORCPT ); Wed, 28 Jun 2017 18:23:12 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:34841 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbdF1WXD (ORCPT ); Wed, 28 Jun 2017 18:23:03 -0400 MIME-Version: 1.0 In-Reply-To: <1498687358-7492-1-git-send-email-longli@exchange.microsoft.com> References: <1498687358-7492-1-git-send-email-longli@exchange.microsoft.com> From: Pavel Shilovsky Date: Wed, 28 Jun 2017 15:23:01 -0700 Message-ID: Subject: Re: [PATCH v3] cifs: Do not modify mid entry after submitting I/O in cifs_call_async To: Long Li Cc: Steve French , linux-cifs , samba-technical , Kernel Mailing List , Long Li Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1720 Lines: 56 2017-06-28 15:02 GMT-07:00 Long Li : > From: Long Li > > In cifs_call_async, server may respond as soon as I/O is submitted. Because > mid entry is freed on the return path, it should not be modified after I/O > is submitted. > > cifs_save_when_sent modifies the sent timestamp in mid entry, and should not > be called after I/O. Call it before I/O. > > Signed-off-by: Long Li > --- > fs/cifs/transport.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c > index 47a125e..f49b73f 100644 > --- a/fs/cifs/transport.c > +++ b/fs/cifs/transport.c > @@ -536,11 +536,13 @@ cifs_call_async(struct TCP_Server_Info *server, struct smb_rqst *rqst, > list_add_tail(&mid->qhead, &server->pending_mid_q); > spin_unlock(&GlobalMid_Lock); > > - > + /* Need to store the time in mid before calling I/O. For call_async, > + * I/O response can come back and free the mid entry on another thread. > + */ > + cifs_save_when_sent(mid); > cifs_in_send_inc(server); > rc = smb_send_rqst(server, rqst, flags); > cifs_in_send_dec(server); > - cifs_save_when_sent(mid); > > if (rc < 0) { > server->sequence_number -= 2; > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Thanks! Please fix the comment style to /* * .... */ Other than that - Reviewed-by: Pavel Shilovsky -- Best regards, Pavel Shilovsky