Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751979AbdF1W3i (ORCPT ); Wed, 28 Jun 2017 18:29:38 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39658 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbdF1W3c (ORCPT ); Wed, 28 Jun 2017 18:29:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 800D2607E2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 28 Jun 2017 15:29:29 -0700 From: Stephen Boyd To: Jassi Brar Cc: Andreas =?iso-8859-1?Q?F=E4rber?= , "linux-arm-kernel@lists.infradead.org" , lkml , Masahiro Yamada , Satoru OKAMOTO , Michael Turquette , linux-clk@vger.kernel.org, Andy Green , Vincent Yang , Tetsuya Nuriya Subject: Re: [PATCH 1/5] clk: mb86s7x: Suppress build Message-ID: <20170628222929.GC5316@codeaurora.org> References: <20170625170020.11791-1-afaerber@suse.de> <20170625170020.11791-2-afaerber@suse.de> <20170628161354.GB5316@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3067 Lines: 59 On 06/28, Jassi Brar wrote: > On 28 June 2017 at 21:43, Stephen Boyd wrote: > > On 06/25, Andreas F?rber wrote: > >> It fails to build once we introduce the ARCH_MB86S7X Kconfig symbol: > >> > >> drivers/clk/clk-mb86s7x.c:27:10: fatal error: soc/mb86s7x/scb_mhu.h: No such file or directory > >> #include > >> ^~~~~~~~~~~~~~~~~~~~~~~ > >> compilation terminated. > >> > >> And when commenting out that line, we get: > >> > >> drivers/clk/clk-mb86s7x.c: In function 'crg_gate_control': > >> drivers/clk/clk-mb86s7x.c:72:8: error: implicit declaration of function 'mb86s7x_send_packet' [-Werror=implicit-function-declaration] > >> ret = mb86s7x_send_packet(CMD_PERI_CLOCK_GATE_SET_REQ, > >> ^~~~~~~~~~~~~~~~~~~ > >> drivers/clk/clk-mb86s7x.c:72:28: error: 'CMD_PERI_CLOCK_GATE_SET_REQ' undeclared (first use in this function) > >> ret = mb86s7x_send_packet(CMD_PERI_CLOCK_GATE_SET_REQ, > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> drivers/clk/clk-mb86s7x.c:72:28: note: each undeclared identifier is reported only once for each function it appears in > >> drivers/clk/clk-mb86s7x.c: In function 'crg_rate_control': > >> drivers/clk/clk-mb86s7x.c:116:10: error: 'CMD_PERI_CLOCK_RATE_SET_REQ' undeclared (first use in this function) > >> code = CMD_PERI_CLOCK_RATE_SET_REQ; > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> drivers/clk/clk-mb86s7x.c:121:10: error: 'CMD_PERI_CLOCK_RATE_GET_REQ' undeclared (first use in this function); did you mean 'CMD_PERI_CLOCK_RATE_SET_REQ'? > >> code = CMD_PERI_CLOCK_RATE_GET_REQ; > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> CMD_PERI_CLOCK_RATE_SET_REQ > >> drivers/clk/clk-mb86s7x.c: In function 'mhu_cluster_rate': > >> drivers/clk/clk-mb86s7x.c:276:10: error: 'CMD_CPU_CLOCK_RATE_GET_REQ' undeclared (first use in this function) > >> code = CMD_CPU_CLOCK_RATE_GET_REQ; > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~ > >> drivers/clk/clk-mb86s7x.c:278:10: error: 'CMD_CPU_CLOCK_RATE_SET_REQ' undeclared (first use in this function); did you mean 'CMD_CPU_CLOCK_RATE_GET_REQ'? > >> code = CMD_CPU_CLOCK_RATE_SET_REQ; > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~ > >> CMD_CPU_CLOCK_RATE_GET_REQ > >> cc1: some warnings being treated as errors > >> scripts/Makefile.build:302: recipe for target > >> 'drivers/clk/clk-mb86s7x.o' failed > >> make[2]: *** [drivers/clk/clk-mb86s7x.o] Error 1 > >> > >> Comment it out in the Makefile for now. > >> > > > > Why not delete the whole driver instead? It's been two years and > > the driver has never compiled. > > > I won't complain. The interest of moving powers evaporated in the > midst of upstreaming. Though some next platform is supposed to reuse > the IPs, but I can't say when will that be upstreamed and by whom. > Thanks for the info. Andreas, can you send a deletion patch instead? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project