Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751666AbdF1XVh (ORCPT ); Wed, 28 Jun 2017 19:21:37 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:36328 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbdF1XVb (ORCPT ); Wed, 28 Jun 2017 19:21:31 -0400 Date: Wed, 28 Jun 2017 18:21:28 -0500 From: Rob Herring To: Eddie James Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, wsa@the-dreams.de, gregkh@linuxfoundation.org, jk@ozlabs.org, joel@jms.id.au, andrew@aj.id.au, "Edward A. James" Subject: Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings Message-ID: <20170628232128.ldglm4fjqivspxn3@rob-hp-laptop> References: <1498505375-1454-1-git-send-email-eajames@linux.vnet.ibm.com> <1498505375-1454-7-git-send-email-eajames@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498505375-1454-7-git-send-email-eajames@linux.vnet.ibm.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1753 Lines: 64 On Mon, Jun 26, 2017 at 02:29:35PM -0500, Eddie James wrote: > From: "Edward A. James" "dt-bindings: i2c: ..." for the subject. > > Document the bindings. > > Signed-off-by: Edward A. James > --- > Documentation/devicetree/bindings/i2c/i2c-fsi.txt | 31 +++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-fsi.txt > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-fsi.txt b/Documentation/devicetree/bindings/i2c/i2c-fsi.txt > new file mode 100644 > index 0000000..fffc067 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/i2c-fsi.txt > @@ -0,0 +1,31 @@ > +Device-tree bindings for FSI-attached I2C master driver > +------------------------------------------------------- > + > +Required properties: > + - compatible = "ibm,i2cm-fsi"; Only one version? > + - reg = < address size >; : The FSI CFAM address and address space > + size. > + - #address-cells = <1>; : Number of address cells in child nodes > + - #size-cells = <0>; : Number of size cells in child nodes. > + - child nodes : Nodes to describe ports off the I2C > + master. > + > +Child node required properties: > + - reg = < port number > : The port number on the I2C master. > + > +Examples: > + > + i2cm@1800 { i2c@1800 > + compatible = "ibm,i2cm-fsi"; > + reg = < 0x1800 0x400 >; > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { The ports are separate i2c buses? Use i2c-bus@... instead. "ports" is already used by OF graph binding. > + reg = <0>; > + }; > + > + port@1 { > + reg = <1>; > + }; > + }; > -- > 1.8.3.1 >