Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751625AbdF1XpK (ORCPT ); Wed, 28 Jun 2017 19:45:10 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:36233 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbdF1XpC (ORCPT ); Wed, 28 Jun 2017 19:45:02 -0400 From: Bjorn Andersson To: Stephen Boyd Cc: Rob Clark , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH] spmi: Include OF based modalias in device uevent Date: Wed, 28 Jun 2017 16:44:58 -0700 Message-Id: <20170628234458.7917-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.12.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1206 Lines: 45 Include the OF-based modalias in the uevent sent when registering SPMI devices, so that user space has a chance to autoload the kernel module for the device. Reported-by: Rob Clark Signed-off-by: Bjorn Andersson --- Based on the MODULE_ALIAS in the qcom-spmi-pmic it's likely that the original author expected that the spmi-pmic-arb would create devices by the identifier "pmic" and the spmi code would include a MODALIAS="spmi:pmic" in the uevent. drivers/spmi/spmi.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c index 2b9b0941d9eb..6d23226e5f69 100644 --- a/drivers/spmi/spmi.c +++ b/drivers/spmi/spmi.c @@ -365,11 +365,23 @@ static int spmi_drv_remove(struct device *dev) return 0; } +static int spmi_drv_uevent(struct device *dev, struct kobj_uevent_env *env) +{ + int ret; + + ret = of_device_uevent_modalias(dev, env); + if (ret != -ENODEV) + return ret; + + return 0; +} + static struct bus_type spmi_bus_type = { .name = "spmi", .match = spmi_device_match, .probe = spmi_drv_probe, .remove = spmi_drv_remove, + .uevent = spmi_drv_uevent, }; /** -- 2.12.0