Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751723AbdF2Beb (ORCPT ); Wed, 28 Jun 2017 21:34:31 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:35430 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbdF2Be1 (ORCPT ); Wed, 28 Jun 2017 21:34:27 -0400 MIME-Version: 1.0 In-Reply-To: <20170629013231.28075-1-mcgrof@kernel.org> References: <20170629013231.28075-1-mcgrof@kernel.org> From: Kees Cook Date: Wed, 28 Jun 2017 18:34:25 -0700 X-Google-Sender-Auth: 1gBl2m9dg1_g7nk3SsDrCo5_MZg Message-ID: Subject: Re: [PATCH] module: make the modinfo name const To: "Luis R. Rodriguez" Cc: Jessica Yu , Rusty Russell , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1175 Lines: 48 On Wed, Jun 28, 2017 at 6:32 PM, Luis R. Rodriguez wrote: > This can be accomplished by makine blacklisted() also accept const. Typo "making" > Signed-off-by: Luis R. Rodriguez But otherwise: Acked-by: Kees Cook -Kees > --- > kernel/module.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/module.c b/kernel/module.c > index 5ebe3ae2519a..7d679f3bb892 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -302,7 +302,7 @@ int unregister_module_notifier(struct notifier_block *nb) > EXPORT_SYMBOL(unregister_module_notifier); > > struct load_info { > - char *name; > + const char *name; > Elf_Ehdr *hdr; > unsigned long len; > Elf_Shdr *sechdrs; > @@ -3382,7 +3382,7 @@ int __weak module_frob_arch_sections(Elf_Ehdr *hdr, > > /* module_blacklist is a comma-separated list of module names */ > static char *module_blacklist; > -static bool blacklisted(char *module_name) > +static bool blacklisted(const char *module_name) > { > const char *p; > size_t len; > -- > 2.10.2 > -- Kees Cook Pixel Security