Date: Sat, 14 Jun 2003 23:03:34 +0200
From: Vojtech Pavlik <vojtech@suse.cz>
To: Oliver Neukum <oliver@neukum.org>
Cc: Russell King <rmk@arm.linux.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [patch] input: Add PCI PS/2 controller support [5/13]
Message-ID: <20030614230334.A26210@ucw.cz>
References: <20030614223513.A25948@ucw.cz> <20030614223934.C25997@ucw.cz> <20030614224022.D25997@ucw.cz> <200306142251.51235.oliver@neukum.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200306142251.51235.oliver@neukum.org>; from oliver@neukum.org on Sat, Jun 14, 2003 at 10:51:51PM +0200
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 907
Lines: 27

On Sat, Jun 14, 2003 at 10:51:51PM +0200, Oliver Neukum wrote:

> > +static int pcips2_write(struct serio *io, unsigned char val)
> > +{
> > +	struct pcips2_data *ps2if = io->driver;
> > +	unsigned int stat;
> > +
> > +	do {
> > +		stat = inb(ps2if->base + PS2_STATUS);
> > +		cpu_relax();
> > +	} while (!(stat & PS2_STAT_TXEMPTY));
> 
> What will happen if somebody unplugs the base station while this
> is running?

I suppose it will wait until you put the base station back. Russell, is
there any notification that the base is getting removed or do all the
loops need checking? I'd consider it not hotpluggable for now.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/