Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751654AbdF2DrW (ORCPT ); Wed, 28 Jun 2017 23:47:22 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:33418 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbdF2DrR (ORCPT ); Wed, 28 Jun 2017 23:47:17 -0400 MIME-Version: 1.0 In-Reply-To: <20170628201032.3178691-1-arnd@arndb.de> References: <20170628201032.3178691-1-arnd@arndb.de> From: Or Gerlitz Date: Thu, 29 Jun 2017 06:47:16 +0300 Message-ID: Subject: Re: [PATCH] [net-next] net/mlx5e: select CONFIG_MLXFW To: Arnd Bergmann , Jakub Kicinski Cc: Saeed Mahameed , "David S. Miller" , Or Gerlitz , Nicolas Pitre , Linux Netdev List , "linux-rdma@vger.kernel.org" , Linux Kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 20 On Wed, Jun 28, 2017 at 11:10 PM, Arnd Bergmann wrote: > With the introduction of mlx5 firmware flash support, we get a link > error with CONFIG_MLXFW=m and CONFIG_MLX5_CORE=y: > > drivers/net/ethernet/mellanox/mlx5/core/fw.o: In function `mlx5_firmware_flash': > fw.c:(.text+0x9d4): undefined reference to `mlxfw_firmware_flash' Thanks Arnd, I got a report on that from Jakub but you were before me here.. > We could have a more elaborate method to force MLX5 to be a loadable > module in this case, but the easiest fix seems to be to always enable > MLXFW as well, like we do for CONFIG_MLXSW_SPECTRUM, which is the other > user of mlxfw_firmware_flash. We would not want to force mlx5 users to build mlxfw. So lets either use the more elaborate method or maybe instead of using IS_ENABLED in mlxfw.h use IS_REACHABLE (this was suggested by Jakub) Or.