Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751712AbdF2ELV (ORCPT ); Thu, 29 Jun 2017 00:11:21 -0400 Received: from mail-pg0-f49.google.com ([74.125.83.49]:35566 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259AbdF2ELO (ORCPT ); Thu, 29 Jun 2017 00:11:14 -0400 Date: Thu, 29 Jun 2017 09:41:10 +0530 From: Viresh Kumar To: Randy Dunlap Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rafael Wysocki , Vincent Guittot , Stephen Boyd , Mark Brown , Shiraz Hashim , Rob Herring , rnayak@codeaurora.org Subject: Re: [RFC 4/5] drivers: boot_constraint: Add debugfs support Message-ID: <20170629041110.GH29665@vireshk-i7> References: <58dbcc2e397fc679af814a9752efa1829885d7f3.1498642745.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 604 Lines: 19 On 28-06-17, 08:46, Randy Dunlap wrote: > On 06/28/2017 03:26 AM, Viresh Kumar wrote: > > This patch adds debugfs support for boot constraints. This is how it > > looks for a "vmmc-supply" constraint for the MMC device. > > > > Hi, > Does this build OK when DEBUG_FS is not enabled in kernel .config? TBH, I haven't tried this earlier as I believed dummy implementation of all the debugfs helpers is available. It needs the following debugfs patch (that I sent just now), which adds the dummy implementation of debugfs_create_ulong(). https://marc.info/?l=linux-kernel&m=149870936319587 -- viresh