Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752172AbdF2HDw (ORCPT ); Thu, 29 Jun 2017 03:03:52 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:46912 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751612AbdF2HDq (ORCPT ); Thu, 29 Jun 2017 03:03:46 -0400 Date: Thu, 29 Jun 2017 09:03:44 +0200 From: Greg Kroah-Hartman To: Chunyan Zhang Cc: Orson Zhai =?utf-8?B?KOe/n+S6rCk=?= , Arnd Bergmann , Zhongping Tan =?utf-8?B?KOiwreS4reW5syk=?= , Linux Kernel Mailing List , songhe.wei@spreadtrum.com Subject: Re: [RFC PATCH] char: misc: Init misc->list in a safe way Message-ID: <20170629070344.GA9037@kroah.com> References: <8f919e212d5149e286422d58a5732356@SHMBX02.spreadtrum.com> <20170627062917.GA10376@kroah.com> <20170628015431.GA32195@spreadtrum.com> <20170628051815.GA4748@kroah.com> <20170628112112.GE7389@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1489 Lines: 40 On Thu, Jun 29, 2017 at 02:54:23PM +0800, Chunyan Zhang wrote: > Hi Greg, > > On 28 June 2017 at 19:21, Greg Kroah-Hartman wrote: > > On Wed, Jun 28, 2017 at 12:34:28PM +0200, Arnd Bergmann wrote: > >> On Wed, Jun 28, 2017 at 7:18 AM, Greg Kroah-Hartman > >> wrote: > >> > On Wed, Jun 28, 2017 at 09:54:32AM +0800, Orson Zhai wrote: > >> >> We found the device is "fm". We highly suspect that fm driver call > >> >> misc_register twice and reinitialize list to make ->pre & ->next > >> >> pointing to himself. > >> >> > >> >> Meanwhile, we checked fm driver and found nothing obviously wrong in the code. > >> > > >> > Do you have a pointer to this driver? Is it in the kernel tree? > >> > >> I found a version of some spreadtrum FM driver in the sources for the > >> Samsung Galaxy > >> J3, this is the driver https://pastebin.com/p7Y7xQNE > > > > Ah nice, Orson, is that the driver? > > For some unknown reason, Orson was missing in this list :) > I'm adding him back. > > This is not the latest version of our FM driver. You can find the > version we're using within Spreadtrum here [1], and the kernel version > we're using is v4.4.49. You forgot the link in your footnote, so we can read the code :) > > Any objection for me adding it to the kernel tree so we can fix up the > > We have no objection to adding this driver to the kernel tree. Great, want me to make up the patch, or do you want to? thanks, greg k-h