Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752143AbdF2HOa (ORCPT ); Thu, 29 Jun 2017 03:14:30 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36690 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbdF2HOX (ORCPT ); Thu, 29 Jun 2017 03:14:23 -0400 Date: Thu, 29 Jun 2017 09:14:14 +0200 From: Ingo Molnar To: Josh Poimboeuf Cc: x86@kernel.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Linus Torvalds , Andy Lutomirski , Jiri Slaby , "H. Peter Anvin" , Peter Zijlstra Subject: Re: [PATCH v2 4/8] objtool: add undwarf debuginfo generation Message-ID: <20170629071414.g4pmbmtegf7jpryz@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1440 Lines: 33 * Josh Poimboeuf wrote: > Now that objtool knows the states of all registers on the stack for each > instruction, it's straightforward to generate debuginfo for an unwinder > to use. > > Instead of generating DWARF, generate a new format called undwarf, which > is more suitable for an in-kernel unwinder. See > tools/objtool/Documentation/undwarf.txt for a more detailed description > of this new debuginfo format and why it's preferable to DWARF. > > Signed-off-by: Josh Poimboeuf > --- > tools/objtool/Build | 3 + > tools/objtool/Documentation/stack-validation.txt | 46 ++--- > tools/objtool/builtin-check.c | 2 +- > tools/objtool/builtin-undwarf.c | 70 ++++++++ > tools/objtool/builtin.h | 1 + > tools/objtool/check.c | 59 ++++++- > tools/objtool/check.h | 15 +- > tools/objtool/elf.c | 212 ++++++++++++++++++++-- > tools/objtool/elf.h | 15 +- > tools/objtool/objtool.c | 3 +- > tools/objtool/undwarf-types.h | 81 +++++++++ Just a very quick stylistic suggestion: please name the header 'undwarf_types.h' (note the underscore versus hyphen), which is the common naming pattern used in the kernel. Thanks, Ingo