Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752210AbdF2Hae (ORCPT ); Thu, 29 Jun 2017 03:30:34 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:35726 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbdF2Ha1 (ORCPT ); Thu, 29 Jun 2017 03:30:27 -0400 MIME-Version: 1.0 In-Reply-To: <20170629070344.GA9037@kroah.com> References: <8f919e212d5149e286422d58a5732356@SHMBX02.spreadtrum.com> <20170627062917.GA10376@kroah.com> <20170628015431.GA32195@spreadtrum.com> <20170628051815.GA4748@kroah.com> <20170628112112.GE7389@kroah.com> <20170629070344.GA9037@kroah.com> From: Chunyan Zhang Date: Thu, 29 Jun 2017 15:30:26 +0800 Message-ID: Subject: Re: [RFC PATCH] char: misc: Init misc->list in a safe way To: Greg Kroah-Hartman Cc: =?UTF-8?B?T3Jzb24gWmhhaSAo57+f5LqsKQ==?= , Arnd Bergmann , =?UTF-8?B?WmhvbmdwaW5nIFRhbiAo6LCt5Lit5bmzKQ==?= , Linux Kernel Mailing List , songhe.wei@spreadtrum.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1853 Lines: 55 ti On 29 June 2017 at 15:03, Greg Kroah-Hartman wrote: > On Thu, Jun 29, 2017 at 02:54:23PM +0800, Chunyan Zhang wrote: >> Hi Greg, >> >> On 28 June 2017 at 19:21, Greg Kroah-Hartman wrote: >> > On Wed, Jun 28, 2017 at 12:34:28PM +0200, Arnd Bergmann wrote: >> >> On Wed, Jun 28, 2017 at 7:18 AM, Greg Kroah-Hartman >> >> wrote: >> >> > On Wed, Jun 28, 2017 at 09:54:32AM +0800, Orson Zhai wrote: >> >> >> We found the device is "fm". We highly suspect that fm driver call >> >> >> misc_register twice and reinitialize list to make ->pre & ->next >> >> >> pointing to himself. >> >> >> >> >> >> Meanwhile, we checked fm driver and found nothing obviously wrong in the code. >> >> > >> >> > Do you have a pointer to this driver? Is it in the kernel tree? >> >> >> >> I found a version of some spreadtrum FM driver in the sources for the >> >> Samsung Galaxy >> >> J3, this is the driver https://pastebin.com/p7Y7xQNE >> > >> > Ah nice, Orson, is that the driver? >> >> For some unknown reason, Orson was missing in this list :) >> I'm adding him back. >> >> This is not the latest version of our FM driver. You can find the >> version we're using within Spreadtrum here [1], and the kernel version >> we're using is v4.4.49. > > You forgot the link in your footnote, so we can read the code :) Ah, my mistake :) [1] https://github.com/sprdlinux/kernel/blob/for-greg/drivers/misc/sprdwcn_bsp/sc2342/radio/fmdrv_ops.c > >> > Any objection for me adding it to the kernel tree so we can fix up the >> >> We have no objection to adding this driver to the kernel tree. > > Great, want me to make up the patch, or do you want to? How do we have the heart to take your precious time :) Anyway, we can do that on our own. Thank you, Chunyan > > thanks, > > greg k-h