Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752208AbdF2HtA (ORCPT ); Thu, 29 Jun 2017 03:49:00 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:34940 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbdF2Hs7 (ORCPT ); Thu, 29 Jun 2017 03:48:59 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170628201032.3178691-1-arnd@arndb.de> From: Arnd Bergmann Date: Thu, 29 Jun 2017 09:48:57 +0200 X-Google-Sender-Auth: bskV_Sw_m4k1UzgGCX6LcWz32CU Message-ID: Subject: Re: [PATCH] [net-next] net/mlx5e: select CONFIG_MLXFW To: Or Gerlitz Cc: Jakub Kicinski , Saeed Mahameed , "David S. Miller" , Or Gerlitz , Nicolas Pitre , Linux Netdev List , "linux-rdma@vger.kernel.org" , Linux Kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1199 Lines: 28 On Thu, Jun 29, 2017 at 5:47 AM, Or Gerlitz wrote: > On Wed, Jun 28, 2017 at 11:10 PM, Arnd Bergmann wrote: >> With the introduction of mlx5 firmware flash support, we get a link >> error with CONFIG_MLXFW=m and CONFIG_MLX5_CORE=y: >> >> drivers/net/ethernet/mellanox/mlx5/core/fw.o: In function `mlx5_firmware_flash': >> fw.c:(.text+0x9d4): undefined reference to `mlxfw_firmware_flash' > > Thanks Arnd, I got a report on that from Jakub but you were before me here.. > >> We could have a more elaborate method to force MLX5 to be a loadable >> module in this case, but the easiest fix seems to be to always enable >> MLXFW as well, like we do for CONFIG_MLXSW_SPECTRUM, which is the other >> user of mlxfw_firmware_flash. > > We would not want to force mlx5 users to build mlxfw. > > So lets either use the more elaborate method or maybe instead of using > IS_ENABLED in mlxfw.h use IS_REACHABLE (this was suggested by Jakub) Sure, that works. I generally try to avoid IS_REACHABLE(), as I find it more confusing than adding a dependency like depends on MLXFW || MLXFW=n (and yes, I was the one who introduced IS_REACHABLE() ;-) ). Arnd