Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526AbdF2Ih5 (ORCPT ); Thu, 29 Jun 2017 04:37:57 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:36425 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090AbdF2Ihy (ORCPT ); Thu, 29 Jun 2017 04:37:54 -0400 MIME-Version: 1.0 In-Reply-To: <14a3d7aa-8038-470a-4166-7da6985241a2@kernel.org> References: <1498214246-1244-1-git-send-email-marcin.nowakowski@imgtec.com> <14a3d7aa-8038-470a-4166-7da6985241a2@kernel.org> From: Fathi Boudra Date: Thu, 29 Jun 2017 11:37:52 +0300 Message-ID: Subject: Re: [PATCH 0/3] kselftest build errors To: Shuah Khan Cc: Marcin Nowakowski , SeongJae Park , linux-kselftest@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1640 Lines: 43 On 28 June 2017 at 17:21, Shuah Khan wrote: > On 06/28/2017 02:30 AM, Fathi Boudra wrote: >> On 23 June 2017 at 22:44, Shuah Khan wrote: >>> On 06/23/2017 04:37 AM, Marcin Nowakowski wrote: >>>> This patch series fixes build errors observed when building net, memfd, gpio and intel_pstate tests >>>> >>>> Marcin Nowakowski (3): >>>> selftests/{net,memfd}: fix undefined references to external libraries >>>> selftests/gpio: fix build error >>>> selftests/intel_pstate: fix undefined reference when building >>>> >>>> tools/testing/selftests/gpio/Makefile | 2 +- >>>> tools/testing/selftests/intel_pstate/Makefile | 2 +- >>>> tools/testing/selftests/memfd/Makefile | 4 ++-- >>>> tools/testing/selftests/net/Makefile | 2 +- >>>> 4 files changed, 5 insertions(+), 5 deletions(-) >>>> >>> >>> Hi Marcin, >>> >>> SeongJae Park sent me fixes for the memfd/net/intel_pstate problems >>> last week. I pulled those in already. >>> >>> The gpio fix is something I need to look at closely to see if this is >>> the way to go. I will get back to you on that. >> >> Any updates on the gpio fix? I've tested it and it works for me. >> > > I haven't decided yet. another alternative is to use realpath: -GPIODIR := ../../../gpio +GPIODIR := $(realpath ../../../gpio) btw, this commit: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=51c6bd7cbe0366b642d8ac90d98739c39ab091a9 should be reverted once the build error is addressed because they shouldn't have been there in the first place due to lack of trailing slash in the path. > thanks, > -- Shuah