Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752602AbdF2JnN (ORCPT ); Thu, 29 Jun 2017 05:43:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:50750 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751758AbdF2JnG (ORCPT ); Thu, 29 Jun 2017 05:43:06 -0400 Date: Thu, 29 Jun 2017 11:42:59 +0200 From: Johannes Thumshirn To: Mauro Carvalho Chehab Cc: Hans Verkuil , Mauro Carvalho Chehab , Linux Kernel Mailinglist , linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, Andrew Morton Subject: Re: [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media Message-ID: <20170629094259.GG3808@linux-x5ow.site> References: <20170621080812.6817-1-jthumshirn@suse.de> <20170624171507.38353b10@vento.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170624171507.38353b10@vento.lan> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1099 Lines: 23 On Sat, Jun 24, 2017 at 05:15:07PM -0300, Mauro Carvalho Chehab wrote: > Sorry, but I can't see any advantage on it. On the downside, it > includes the media controller header file (media.h) where it > is not needed. My reasoning was the differences in semantics. KERNEL_VERSION() is for encoding the kernel's version triplet not a API or Hardware or whatever version. Other subsystems do this as well, for instance in NVMe we have the NVME_VS() macro which is used to encode the NVMe Spec compliance from a human readable form to the hardware's u32. Also KERNEL_VERISON() shouldn't have in-tree users IMHO. Yes there is _one_ other user of it in-tree which is EXT4 and I already talked to Jan Kara about it and we decided to leave it in until 4.20. Byte, Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850