Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633AbdF2Jop (ORCPT ); Thu, 29 Jun 2017 05:44:45 -0400 Received: from mail-it0-f46.google.com ([209.85.214.46]:38266 "EHLO mail-it0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752532AbdF2Jof (ORCPT ); Thu, 29 Jun 2017 05:44:35 -0400 MIME-Version: 1.0 In-Reply-To: <20170623122952.9871-2-gregory.clement@free-electrons.com> References: <20170623122952.9871-1-gregory.clement@free-electrons.com> <20170623122952.9871-2-gregory.clement@free-electrons.com> From: Linus Walleij Date: Thu, 29 Jun 2017 11:44:33 +0200 Message-ID: Subject: Re: [PATCH 1/2] pinctrl: armada-37xx: Fix uart2 group selection register mask To: Gregory CLEMENT Cc: "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ken Ma , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , "linux-arm-kernel@lists.infradead.org" , Stefan Roese , Nadav Haklai , Victor Gu , Marcin Wojtas , Wilson Ding , Hua Jing , Neta Zur Hershkovits Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 625 Lines: 18 On Fri, Jun 23, 2017 at 2:29 PM, Gregory CLEMENT wrote: > From: Ken Ma > > If north bridge selection register bit1 is clear, pins [10:8] are for > SDIO0 Resetn, Wakeup, and PDN while if bit1 is set, pins [10:8]are for > GPIO; when bit1 is clear, pin 9 and pin 10 can be used for uart2 RTSn > and CTSn, so bit1 should be added to uart2 group and it must be set > for both "gpio" and "uart" functions of uart2 group. > > Signed-off-by: Ken Ma > Signed-off-by: Gregory CLEMENT Patch applied. Yours, Linus Walleij