Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752631AbdF2Jy3 (ORCPT ); Thu, 29 Jun 2017 05:54:29 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:33663 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752536AbdF2JyR (ORCPT ); Thu, 29 Jun 2017 05:54:17 -0400 Subject: Re: [PATCH 03/14] qcom: mtd: nand: Fixed config error for BCH To: Abhishek Sahu , dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, richard@nod.at, cyrille.pitchen@wedev4u.fr, robh+dt@kernel.org, mark.rutland@arm.com References: <1498720566-20782-1-git-send-email-absahu@codeaurora.org> <1498720566-20782-4-git-send-email-absahu@codeaurora.org> Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, architt@codeaurora.org, sricharan@codeaurora.org From: Marek Vasut Message-ID: Date: Thu, 29 Jun 2017 11:49:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1498720566-20782-4-git-send-email-absahu@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 30 On 06/29/2017 09:15 AM, Abhishek Sahu wrote: > The configuration for BCH is not correct in the current > driver so this patch fixed the same. Fix the commit message, I have no idea what this patch does or fixes. > Signed-off-by: Abhishek Sahu > --- > drivers/mtd/nand/qcom_nandc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c > index 520add9..410ee53 100644 > --- a/drivers/mtd/nand/qcom_nandc.c > +++ b/drivers/mtd/nand/qcom_nandc.c > @@ -1919,7 +1919,7 @@ static int qcom_nand_host_setup(struct qcom_nand_host *host) > | wide_bus << WIDE_FLASH > | 1 << DEV0_CFG1_ECC_DISABLE; > > - host->ecc_bch_cfg = host->bch_enabled << ECC_CFG_ECC_DISABLE > + host->ecc_bch_cfg = !host->bch_enabled << ECC_CFG_ECC_DISABLE > | 0 << ECC_SW_RESET > | host->cw_data << ECC_NUM_DATA_BYTES > | 1 << ECC_FORCE_CLK_OPEN > -- Best regards, Marek Vasut