Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbdF2Kdx (ORCPT ); Thu, 29 Jun 2017 06:33:53 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33373 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbdF2Kdt (ORCPT ); Thu, 29 Jun 2017 06:33:49 -0400 From: Arvind Yadav To: perex@perex.cz, tiwai@suse.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ALSA: pcm: constify attribute_group structures. Date: Thu, 29 Jun 2017 16:02:56 +0530 Message-Id: <51656954c56bb69937adee61e23eec07b3bc08d0.1498729390.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 967 Lines: 32 attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 9781 240 8 10029 272d sound/core/pcm.o File size After adding 'const': text data bss dec hex filename 9813 176 8 9997 270d sound/core/pcm.o Signed-off-by: Arvind Yadav --- sound/core/pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/pcm.c b/sound/core/pcm.c index 8e980aa..ee3e8db0 100644 --- a/sound/core/pcm.c +++ b/sound/core/pcm.c @@ -1056,7 +1056,7 @@ static ssize_t show_pcm_class(struct device *dev, NULL }; -static struct attribute_group pcm_dev_attr_group = { +static const struct attribute_group pcm_dev_attr_group = { .attrs = pcm_dev_attrs, }; -- 1.9.1