Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752819AbdF2LkY (ORCPT ); Thu, 29 Jun 2017 07:40:24 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36592 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752384AbdF2LkG (ORCPT ); Thu, 29 Jun 2017 07:40:06 -0400 MIME-Version: 1.0 In-Reply-To: <87shij9nhl.fsf@concordia.ellerman.id.au> References: <20170629065802.24062-1-fathi.boudra@linaro.org> <87shij9nhl.fsf@concordia.ellerman.id.au> From: Fathi Boudra Date: Thu, 29 Jun 2017 14:39:58 +0300 Message-ID: Subject: Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS To: Michael Ellerman Cc: linux-kselftest@vger.kernel.org, Shuah Khan , "linux-kernel@vger.kernel.org" , Bamvor Jian Zhang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 21 On 29 June 2017 at 12:01, Michael Ellerman wrote: > Fathi Boudra writes: > >> Fix hardcoded and misplaced libmount headers. Use pkg-config instead to >> figure out CFLAGS/LDLIBS, fixing also their value for cross-compilation. > > Can you explain how it fixes the values for cross-compilation? When pkg-config is invoked in a cross-build environment, it will return your sysroot headers path instead of the hardcoded -I/usr/include/libmount For example in my oe environment, when I invoke "pkg-config --cflags mount", it returns: -I/build/tmp-rpb-glibc/sysroots/hikey/usr/include/libmount > cheers > -- > To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html