Date: Thu, 29 Jun 2017 14:59:31 +0300
From: Baruch Siach <baruch@tkos.co.il>
To: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: nicolas.ferre@microchip.com, alexandre.belloni@free-electrons.com,
        robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
        sza@esh.hu, devicetree@vger.kernel.org, cristian.birsan@microchip.com,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] ARM: dts: sama5d27_som1_ek: Add sama5d27 SoM1 EK
 support
Message-ID: <20170629115931.yki2xbehyicbtx3w@tarshish>
References: <1498736674-9233-1-git-send-email-claudiu.beznea@microchip.com>
 <1498736674-9233-6-git-send-email-claudiu.beznea@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1498736674-9233-6-git-send-email-claudiu.beznea@microchip.com>
User-Agent: NeoMutt/20170306 (1.8.0)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 856
Lines: 31

Hi Claudiu,

On Thu, Jun 29, 2017 at 02:44:34PM +0300, Claudiu Beznea wrote:
> Add specifig DTS files and bindings for sama5d27 SoM1 EK board.

Is there any publicly available information on this SoM?

One more comment below.

> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
> ---

[snip]

> +	memory {
> +		reg = <0x20000000 0x20000>;

Are you sure this SoM has 132KB RAM?

Since you seem to rely on the bootloader to fill in the right size value, you 
can just drop this node and rely on sama5d2.dtsi that provides a stub node.

> +	};

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -