Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752744AbdF2L7y (ORCPT ); Thu, 29 Jun 2017 07:59:54 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:34124 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752420AbdF2L7o (ORCPT ); Thu, 29 Jun 2017 07:59:44 -0400 Date: Thu, 29 Jun 2017 13:59:41 +0200 From: Pavel Machek To: Arvind Yadav Cc: rjw@rjwysocki.net, len.brown@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PM: hibernate: constify attribute_group structures. Message-ID: <20170629115941.GA11525@amd> References: <06cb04785b169107e86016267fd52b414e46efaa.1498735541.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline In-Reply-To: <06cb04785b169107e86016267fd52b414e46efaa.1498735541.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1260 Lines: 42 --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2017-06-29 16:58:40, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. >=20 > File size before: > text data bss dec hex filename > 6332 488 308 7128 1bd8 kernel/power/hibernate.o >=20 > File size After adding 'const': > text data bss dec hex filename > 6396 424 308 7128 1bd8 kernel/power/hibernate.o >=20 > Signed-off-by: Arvind Yadav Acked-by: Pavel Machek --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAllU660ACgkQMOfwapXb+vLowwCgu8FTHom7u1QI+7FaO9Jm2n4k opwAn1QlDvvQ4FkmME3D3eA+SwvC+W4C =KC1y -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z--