Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752790AbdF2MLO (ORCPT ); Thu, 29 Jun 2017 08:11:14 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35802 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752378AbdF2MK6 (ORCPT ); Thu, 29 Jun 2017 08:10:58 -0400 From: Arvind Yadav To: tglx@linutronix.de, bigeasy@linutronix.de, mingo@kernel.org, anna-maria@linutronix.de, boris.ostrovsky@oracle.com, rcochran@linutronix.de, torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] kernel: cpu: hotplug: constify attribute_group structures. Date: Thu, 29 Jun 2017 17:40:47 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1249 Lines: 41 attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 12582 15361 20 27963 6d3b kernel/cpu.o File size After adding 'const': text data bss dec hex filename 12710 15265 20 27995 6d5b kernel/cpu.o Signed-off-by: Arvind Yadav --- kernel/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/cpu.c b/kernel/cpu.c index 9ae6fbe..45455f9 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -1684,7 +1684,7 @@ static ssize_t show_cpuhp_target(struct device *dev, NULL }; -static struct attribute_group cpuhp_cpu_attr_group = { +static const struct attribute_group cpuhp_cpu_attr_group = { .attrs = cpuhp_cpu_attrs, .name = "hotplug", NULL @@ -1716,7 +1716,7 @@ static ssize_t show_cpuhp_states(struct device *dev, NULL }; -static struct attribute_group cpuhp_cpu_root_attr_group = { +static const struct attribute_group cpuhp_cpu_root_attr_group = { .attrs = cpuhp_cpu_root_attrs, .name = "hotplug", NULL -- 1.9.1