Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752929AbdF2MXV (ORCPT ); Thu, 29 Jun 2017 08:23:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38332 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752143AbdF2MXQ (ORCPT ); Thu, 29 Jun 2017 08:23:16 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 27B2073B2A Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jeyu@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 27B2073B2A Date: Thu, 29 Jun 2017 14:23:12 +0200 From: Jessica Yu To: "Luis R. Rodriguez" Cc: rusty@rustcorp.com.au, keescook@chromium.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] module: make the modinfo name const Message-ID: <20170629122310.auawf7adi6p3i47r@redbean> References: <20170629013231.28075-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170629013231.28075-1-mcgrof@kernel.org> X-OS: Linux redbean 4.11.5-200.fc25.x86_64 x86_64 User-Agent: NeoMutt/20170609 (1.8.3) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 29 Jun 2017 12:23:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 979 Lines: 36 +++ Luis R. Rodriguez [28/06/17 18:32 -0700]: >This can be accomplished by makine blacklisted() also accept const. > >Signed-off-by: Luis R. Rodriguez Applied, thanks! >--- > kernel/module.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/kernel/module.c b/kernel/module.c >index 5ebe3ae2519a..7d679f3bb892 100644 >--- a/kernel/module.c >+++ b/kernel/module.c >@@ -302,7 +302,7 @@ int unregister_module_notifier(struct notifier_block *nb) > EXPORT_SYMBOL(unregister_module_notifier); > > struct load_info { >- char *name; >+ const char *name; > Elf_Ehdr *hdr; > unsigned long len; > Elf_Shdr *sechdrs; >@@ -3382,7 +3382,7 @@ int __weak module_frob_arch_sections(Elf_Ehdr *hdr, > > /* module_blacklist is a comma-separated list of module names */ > static char *module_blacklist; >-static bool blacklisted(char *module_name) >+static bool blacklisted(const char *module_name) > { > const char *p; > size_t len; >-- >2.10.2 >