Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753186AbdF2Mvb (ORCPT ); Thu, 29 Jun 2017 08:51:31 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41280 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753109AbdF2MvQ (ORCPT ); Thu, 29 Jun 2017 08:51:16 -0400 Date: Thu, 29 Jun 2017 14:51:04 +0200 From: Greg KH To: Shaohua Li Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, tj@kernel.org, hch@lst.de, axboe@fb.com, rostedt@goodmis.org, lizefan@huawei.com, Kernel-team@fb.com, Shaohua Li Subject: Re: [PATCH V4 04/12] kernfs: don't set dentry->d_fsdata Message-ID: <20170629125104.GD26046@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 642 Lines: 14 On Wed, Jun 28, 2017 at 09:29:54AM -0700, Shaohua Li wrote: > From: Shaohua Li > > When working on adding exportfs operations in kernfs, I found it's hard > to initialize dentry->d_fsdata in the exportfs operations. Looks there > is no way to do it without race condition. Look at the kernfs code > closely, there is no point to set dentry->d_fsdata. inode->i_private > already points to kernfs_node, and we can get inode from a dentry. So > this patch just delete the d_fsdata usage. > > Acked-by: Tejun Heo > Signed-off-by: Shaohua Li Acked-by: Greg Kroah-Hartman