Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753109AbdF2Mxb (ORCPT ); Thu, 29 Jun 2017 08:53:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:39927 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752807AbdF2MxX (ORCPT ); Thu, 29 Jun 2017 08:53:23 -0400 Subject: Re: [PATCH 3/5] dt-bindings: arm: Document Socionext MB86S71 and Fujitsu F-Cue To: Masahiro Yamada Cc: Rob Herring , linux-arm-kernel , Linux Kernel Mailing List , Satoru OKAMOTO , Mark Rutland , devicetree@vger.kernel.org References: <20170625170020.11791-1-afaerber@suse.de> <20170625170020.11791-4-afaerber@suse.de> <20170628164605.2gnvrv4g7jluzyrm@rob-hp-laptop> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <51221840-b08e-45f1-5601-937fb15f3947@suse.de> Date: Thu, 29 Jun 2017 14:53:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2328 Lines: 56 Hi Masahiro-san, Am 29.06.2017 um 14:18 schrieb Masahiro Yamada: > 2017-06-29 1:46 GMT+09:00 Rob Herring : >> On Sun, Jun 25, 2017 at 07:00:18PM +0200, Andreas Färber wrote: >>> For consistency with existing SoC bindings, use "fujitsu,mb86s71" but >>> socionext.txt. >>> >>> Signed-off-by: Andreas Färber >>> --- >>> Documentation/devicetree/bindings/arm/socionext.txt | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/arm/socionext.txt >> >> Acked-by: Rob Herring >> -- > > I do not mind this, but > please note there are multiple product lines in Socionext > because Socionext merged LSI divisions from Panasonic and Fujitsu. > > I maintain documents for Socionext UniPhier SoC family > (which inherits SoC architecture of Panasonic) > in Documentation/devicetree/bindings/arm/uniphier/. Actually you seemed to be lacking bindings beyond the cache controller for Uniphier: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/arm/uniphier The SoC compatible, e.g. "socionext,uniphier-ld11", needs to be defined somewhere too, as done here. A git-grep for that particular compatible only finds derived clk and reset bindings. Using socionext.txt allows you to add those bindings to a shared file; if you prefer to host them separately below uniphier/ or as uniphier.txt do you have a better name suggestion for this one? I was trying to keep our options open to later add SC2A11 in socionext.txt, and I also saw some mb8ac300 or so (MB86S7x predecessor?) in downstream sources, so I don't know a good common name for the non-Panasonic parts. And if we take fujitsu.txt for MB86S7x to match the vendor prefix then we will need a separate file for the new SC2A11 IIUC. Also if you can tell us where the cut between Fujitsu and Socionext should be done, we can certainly adapt. NXP is still adding all their new SoCs in fsl.txt, it seems. (A similar naming issue exists for my not-yet-submitted FM4 patches, where it changed owners from Fujitsu to Spansion and then to Cypress.) Best regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)