Message-ID: <1498742557.8633.12.camel@perches.com>
Subject: Re: [PATCH v2 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile
 is  usually wrong
From: Joe Perches <joe@perches.com>
To: Jaya Durga <rjdurga@gmail.com>, gregkh@linuxfoundation.org
Cc: sergio.paracuellos@gmail.com, juliana.orod@gmail.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        Jaya Durga <jayad@cdac.in>
Date: Thu, 29 Jun 2017 06:22:37 -0700
In-Reply-To: <1498741260-23676-7-git-send-email-rjdurga@gmail.com>
References: <1498741260-23676-7-git-send-email-rjdurga@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 856
Lines: 23

On Thu, 2017-06-29 at 18:31 +0530, Jaya Durga wrote:
> Fix checkpatch.pl issue
> WARNING: Use of volatile is usually wrong:
> see Documentation/process/volatile-considered-harmful.rst
> 
> The variables in the private data that are
> marked volatile don't need to be. Remove the volatile.

If you examine the code that uses reapable,
it appears reapable should not be an int
but instead should be an enum cmd_mode.

> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
[]
> @@ -1175,7 +1175,7 @@ struct hfa384x_usbctlx {
>  	enum ctlx_state state;	/* Tracks running state */
>  
>  	struct completion done;
> -	volatile int reapable;	/* Food for the reaper task */
> +	int reapable;	/* Food for the reaper task */
>  
>  	ctlx_cmdcb_t cmdcb;	/* Async command callback */
>  	ctlx_usercb_t usercb;	/* Async user callback, */