Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753261AbdF2Ny4 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 29 Jun 2017 09:54:56 -0400
Received: from mga07.intel.com ([134.134.136.100]:28735 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753129AbdF2Nyv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Jun 2017 09:54:51 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,281,1496127600"; 
   d="scan'208";a="280158351"
Reply-To: thor.thayer@linux.intel.com
Subject: Re: [PATCH] EDAC: Get rid of mci->mod_ver
To: Borislav Petkov <bp@alien8.de>,
        linux-edac <linux-edac@vger.kernel.org>
Cc: Mark Gross <mark.gross@intel.com>, Robert Richter <rric@kernel.org>,
        Tim Small <tim@buttersideup.com>,
        Ranganathan Desikan <ravi@jetztechnologies.com>,
        "Arvind R." <arvino55@gmail.com>, Jason Baron <jbaron@akamai.com>,
        Tony Luck <tony.luck@intel.com>,
        Michal Simek <michal.simek@xilinx.com>,
        =?UTF-8?Q?S=c3=b6ren_Brinkmann?= <soren.brinkmann@xilinx.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        David Daney <david.daney@cavium.com>, Loc Ho <lho@apm.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mips@linux-mips.org
References: <20170629100311.vmdq6fojpo5ye4ne@pd.tnic>
From: Thor Thayer <thor.thayer@linux.intel.com>
Message-ID: <deade91d-7326-8a39-3881-50db582c3098@linux.intel.com>
Date: Thu, 29 Jun 2017 08:57:57 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170629100311.vmdq6fojpo5ye4ne@pd.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1364
Lines: 49

On 06/29/2017 05:03 AM, Borislav Petkov wrote:
> Hi,
> 
> any objections?
> 
> ---
> It is a write-only variable so get rid of it.
> 
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Thor Thayer <thor.thayer@linux.intel.com>
> Cc: Mark Gross <mark.gross@intel.com>
> Cc: Robert Richter <rric@kernel.org>
> Cc: Tim Small <tim@buttersideup.com>
> Cc: Ranganathan Desikan <ravi@jetztechnologies.com>
> Cc: "Arvind R." <arvino55@gmail.com>
> Cc: Jason Baron <jbaron@akamai.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: David Daney <david.daney@cavium.com>
> Cc: Loc Ho <lho@apm.com>
> Cc: linux-edac@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-mips@linux-mips.org
> ---
>   drivers/edac/altera_edac.c      | 2 --

<snip>

> 
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index db75d4b614f7..fa2e5db56d24 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -38,7 +38,6 @@
>   #include "edac_module.h"
>   
>   #define EDAC_MOD_STR		"altera_edac"
> -#define EDAC_VERSION		"1"
>   #define EDAC_DEVICE		"Altera"
>   

<snip>

Looks fine for Altera EDAC.

Acked-by: Thor Thayer <thor.thayer@linux.intel.com>