Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752835AbdF2OIH (ORCPT ); Thu, 29 Jun 2017 10:08:07 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:43722 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752796AbdF2OIA (ORCPT ); Thu, 29 Jun 2017 10:08:00 -0400 Subject: Re: [PATCH v1 2/2] drm: rcar-du: Repair vblank for DRM page flips using the VSP1 To: Kieran Bingham , linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com Cc: David Airlie , Mauro Carvalho Chehab , open list References: <1f52573cfb6e72b49af7a1071ffe136623fafc75.1498744799.git-series.kieran.bingham+renesas@ideasonboard.com> Reply-To: kieran.bingham@ideasonboard.com From: Kieran Bingham Organization: Ideas on Board Message-ID: <45eba5b6-d5a2-1007-1af5-2a076dd0630e@ideasonboard.com> Date: Thu, 29 Jun 2017 15:07:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1f52573cfb6e72b49af7a1071ffe136623fafc75.1498744799.git-series.kieran.bingham+renesas@ideasonboard.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 582 Lines: 20 > @@ -658,10 +660,14 @@ static irqreturn_t rcar_du_crtc_irq(int irq, void *arg) > rcar_du_crtc_write(rcrtc, DSRCR, status & DSRCR_MASK); > > if (status & DSSR_FRM) { > - drm_crtc_handle_vblank(&rcrtc->crtc); > - > - if (rcdu->info->gen < 3) > + /* > + * Gen 3 vblank and page flips are handled through the VSP > + * completion handler > + */ > + if (rcdu->info->gen < 3) { Of course as is obvious immediately after hitting send, this check was supposed to be removed now that the interrupt is not registered. Sorry for the noise and pre-released patch! -- Kieran