Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753307AbdF2ORy (ORCPT ); Thu, 29 Jun 2017 10:17:54 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52568 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753115AbdF2ORr (ORCPT ); Thu, 29 Jun 2017 10:17:47 -0400 Date: Thu, 29 Jun 2017 16:17:45 +0200 From: Greg KH To: Arvind Yadav Cc: lkp@intel.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: ccree: constify dev_pm_ops structures. Message-ID: <20170629141745.GA29512@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 869 Lines: 24 On Thu, Jun 29, 2017 at 03:00:28PM +0530, Arvind Yadav wrote: > dev_pm_ops are not supposed to change at runtime. All functions > working with dev_pm_ops provided by work with const > dev_pm_ops. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 3800 488 0 4288 10c0 drivers/staging/ccree/ssi_driver.o > > File size After adding 'const': > text data bss dec hex filename > 4010 288 0 4298 10ca drivers/staging/ccree/ssi_driver.o > > Signed-off-by: Arvind Yadav > --- > drivers/staging/ccree/ssi_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) No longer applies to my staging-testing branch at all due to other changes happening there. Please rebase and resend. thanks, greg k-h